- logs and empty suggestion

Author: VenInf

plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal.hs

@@ -344,7 +344,7 @@ cabalAddCodeAction recorder state plId (CodeActionParams _ _ (TextDocumentIdenti
         Just haskellFilePath -> do
           mbCabalFile <- liftIO $ CabalAdd.findResponsibleCabalFile haskellFilePath
           case mbCabalFile of
-            Nothing -> pure $ InL [InR noCabalFileAction]
+            Nothing -> pure $ InL []
             Just cabalFilePath -> do
               verTxtDocId <- lift $ pluginGetVersionedTextDoc $ TextDocumentIdentifier (filePathToUri cabalFilePath)
               mbGPD <- liftIO $ runAction "cabal.cabal-add" state $ useWithStale ParseCabalFile $ toNormalizedFilePath cabalFilePath
@@ -356,8 +356,6 @@ cabalAddCodeAction recorder state plId (CodeActionParams _ _ (TextDocumentIdenti
                                                                               haskellFilePath cabalFilePath gpd
                   pure $ InL $ fmap InR actions
   where
-    noCabalFileAction = CodeAction "No .cabal file found" (Just CodeActionKind_QuickFix) (Just []) Nothing
-                                     (Just (CodeActionDisabled "No .cabal file found")) Nothing Nothing Nothing
     cabalAddRecorder = cmapWithPrio LogCabalAdd recorder
 
 

plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd.hs

@@ -85,7 +85,6 @@ import           Text.Regex.TDFA
 
 data Log
   = LogFoundResponsibleCabalFile FilePath
-  | LogCalledCabalAddCodeAction
   | LogCalledCabalAddCommand CabalAddCommandParams
   | LogCreatedEdit WorkspaceEdit
   | LogExecutedCommand
@@ -94,7 +93,6 @@ data Log
 instance Pretty Log where
     pretty = \case
       LogFoundResponsibleCabalFile fp -> "Located the responsible cabal file at " <+> pretty fp
-      LogCalledCabalAddCodeAction -> "The CabalAdd CodeAction is called"
       LogCalledCabalAddCommand params -> "Called CabalAdd command with:\n" <+> pretty params
       LogCreatedEdit edit -> "Created inplace edit:\n" <+> pretty edit
       LogExecutedCommand -> "Executed CabalAdd command"
@@ -143,7 +141,6 @@ addDependencySuggestCodeAction
   -> IO [CodeAction]
 addDependencySuggestCodeAction recorder plId verTxtDocId suggestions haskellFilePath cabalFilePath gpd = do
     buildTargets <- liftIO $ getBuildTargets gpd cabalFilePath haskellFilePath
-    logWith recorder Info LogCalledCabalAddCodeAction
     case buildTargets of
       [] -> pure $ mkCodeAction cabalFilePath Nothing <$> suggestions
       targets -> pure $ concat [mkCodeAction cabalFilePath (Just $ buildTargetToStringRepr target) <$>