Skip to content

fix(server): email address validation #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2022

Conversation

tochicool
Copy link
Contributor

Fixes #1073

@gbaz
Copy link
Contributor

gbaz commented May 15, 2022

Thanks!

@gbaz gbaz merged commit 1c35e03 into haskell:master May 15, 2022
@ysangkok
Copy link
Member

Hmm, had I broken this in #1047? I thought I just moved code around.

@ysangkok
Copy link
Member

Oh indeed I did, by trying to prevent more than one at-sign. I had misunderstood what span does:

Prelude Data.Text> Data.Text.span (/= '@') $ pack "a@b.com"
("a","@b.com")

Sorry.

@andreasabel
Copy link
Member

@ysangkok wrote:

Sorry.

Better unit test than sorry. ;-)

More seriously, I am worried that there is no beta deployment of Hackage. I voiced this during one of our jitsi meetings. I remember @gbaz saying that this is technically difficult. In principle, this should not be difficult. The database layer of Hackage needs to be separated from the UI layer, so that different UIs can connect to the same database. Maybe the current architecture does not permit this. Then we need to get some money to get the architecture modernized by some professionals like Well-Typed (who did the original architecture, AFAIK).

@andreasabel
Copy link
Member

Better unit test than sorry. ;-)

Unit tests added in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot register new accounts
4 participants