Don't use the RecordWildcards trick

Author: jhrcek

hackage-server.cabal

@@ -125,7 +125,7 @@ common defaults
     , vector                ^>= 0.12
     , zlib                  ^>= 0.6.2
 
-  ghc-options: -Wall -fwarn-tabs -fno-warn-unused-do-bind -fno-warn-deprecated-flags -fwarn-incomplete-record-updates -funbox-strict-fields
+  ghc-options: -Wall -fwarn-tabs -fno-warn-unused-do-bind -fno-warn-deprecated-flags -funbox-strict-fields
 
   if impl(ghc >= 8.2)
     ghc-options: -Werror=incomplete-patterns -Werror=missing-methods

src/Distribution/Server/Features/Users.hs

@@ -496,7 +496,7 @@ userFeature templates usersState adminsState
           let resp' = fromMaybe defaultResponse overrideResponse
               -- reset authn to "0" on auth failures
               resp'' = case resp' of
-                ErrorResponse{..} -> ErrorResponse { errorHeaders = ("Set-Cookie","authn=\"0\";Path=/;Version=\"1\""):errorHeaders, .. }
+                r@ErrorResponse{} -> r { errorHeaders = ("Set-Cookie","authn=\"0\";Path=/;Version=\"1\""):errorHeaders r }
                 GenericErrorResponse -> GenericErrorResponse
           throwError resp''
 

src/Distribution/Server/Framework/HappstackUtils.hs

@@ -1,4 +1,4 @@
-{-# LANGUAGE FlexibleContexts, RecordWildCards #-}
+{-# LANGUAGE FlexibleContexts #-}
 {-|
 
 Functions and combinators to expose functioanlity buiding
@@ -172,14 +172,14 @@ enableGZip compressParams modifyETag = do
   where
     gzipFilter :: Response -> Response
     gzipFilter r@SendFile{} = r -- Leave files alone
-    gzipFilter Response{..} =
+    gzipFilter r@Response{} =
         chunked
       . setHeader "Content-Encoding" "gzip"
       . setHeader "Vary" "Accept-Encoding"
       . removeResponseHeader "Content-Length"
       . removeResponseHeader "Content-MD5"
       . alterResponseHeader "ETag" (map modifyETag)
-      $ Response { rsBody = GZip.compressWith compressParams rsBody, .. }
+      $ r { rsBody = GZip.compressWith compressParams $ rsBody r }
 
 -- | Variation on 'enableGZip' with sensible defaults
 --
@@ -216,14 +216,12 @@ enableRange = do
     -- out the original length.
     rangeFilter :: (Int64, Int64) -> Response -> Response
     rangeFilter _ r@SendFile{} = r
-    rangeFilter (fr, to) r@Response{..} =
+    rangeFilter (fr, to) r@Response{} =
         setHeader "Content-Length" (show rangeLen)
       . setHeaderBS (BS.C8.pack "Content-Range") (contentRange fr to fullLen)
       . removeResponseHeader "Content-MD5"
-      $ Response
-          { rsBody = BS.Lazy.take rangeLen $ BS.Lazy.drop fr rsBody
+      $ r { rsBody = BS.Lazy.take rangeLen $ BS.Lazy.drop fr $ rsBody r
           , rsCode = 206
-          , ..
           }
       where
         rangeLen = to - fr + 1