-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offline flag disables source-repository-package
sync
#9771
Conversation
I do wonder if this should print something (not sure if level info or warning) when skipping due to being offline. |
I have implemented a warning. However, it is still followed by a cryptic error message:
If the dependency is cached, there is only a warning
|
418932f
to
b8bcea1
Compare
@geekosaur , can this be merged? Thanks |
It needs another reviewer; I've attached the needs-review label, which hopefully will get some more eyes on it. |
Thank you |
I'll add the "merge me" label for you per the PR guidelines. There will then be a 2 day cooldown period to let others comment on the PR before Mergify merges it. |
haskell#9641 warning when offline mode skips `source-repository-package`s i.e. ``` Warning: --offline was specified, skipping sync of repositories: Warning: https://github.com/haskell/text.git ```
b8bcea1
to
df8f0c5
Compare
@Mergifyio backport 3.12 |
✅ Backports have been created
|
offline flag disables `source-repository-package` sync (backport #9771)
Closes: #9641
How this was tested:
text
library as asource-repository-package
cabal install cabal --overwrite-policy=always
dist-newstyle
to remove thetext
library cached thererm -rf dist-newstyle; ~/.cabal/bin/cabal build
text
library pulled, build succeedstext
library andoffline
flag~/.cabal/bin/cabal build --offline
dist-newstyle
again, and attempt build with--offline
rm -rf dist-newstyle; ~/.cabal/bin/cabal build --offline
text
library from being pulledPlease read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies
cabal
behaviourInclude the following checklist in your PR: