Skip to content

Document the pkg: prefix for package targets #9015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2023
Merged

Document the pkg: prefix for package targets #9015

merged 1 commit into from
Jun 23, 2023

Conversation

michaelpj
Copy link
Collaborator

As discussed in #9009

geekosaur
geekosaur approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulysses4ever ulysses4ever added the merge me Tell Mergify Bot to merge label Jun 12, 2023
jneira
jneira reviewed Jun 12, 2023
View reviewed changes
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 14, 2023
@ulysses4ever
Copy link
Collaborator

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2023

rebase

✅ Branch has been successfully rebased

@ulysses4ever
Copy link
Collaborator

Some Windows unhappiness on CI. Trying to restart.

@ulysses4ever
Copy link
Collaborator

Hmm, that didn't help…

@ulysses4ever ulysses4ever added the attention: needs-help Help wanted with this issue/PR label Jun 20, 2023
@gbaz
Copy link
Collaborator

gbaz commented Jun 20, 2023

the sporadic failing test could be fixed probably by something like using this

cabal/cabal-install/tests/UnitTests/TempTestDir.hs

Line 43 in 24934dd

removeDirectoryRecursiveHack :: Verbosity -> FilePath -> IO ()

@ulysses4ever
Copy link
Collaborator

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2023

rebase

✅ Branch has been successfully rebased

@ulysses4ever
Copy link
Collaborator

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2023

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit 6c3bd39 into haskell:master Jun 23, 2023
@ulysses4ever
Copy link
Collaborator

@Kleidukos how do you feel about backporting documentation improvements? May be a cheap and nice improvement for 3.10.2. Hopefully won't need manual intervention (fourmolu doesn't touch .rst files).

@Kleidukos
Copy link
Member

yep that's a good one, thank you

@Kleidukos
Copy link
Member

@Mergifyio backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2023 •
edited
Loading

backport 3.10

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jul 1, 2023
Merged
Kleidukos pushed a commit that referenced this pull request Jul 1, 2023
@mergify @michaelpj
Document the pkg: prefix for package targets (backport #9015) (#9079)
c7915c2 
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira left review comments

@ulysses4ever ulysses4ever ulysses4ever left review comments

@geekosaur geekosaur geekosaur approved these changes

@Kleidukos Kleidukos Kleidukos approved these changes

Assignees
No one assigned
Labels
attention: needs-help Help wanted with this issue/PR merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michaelpj @ulysses4ever @gbaz @Kleidukos @jneira @geekosaur