Skip to content

Default to cabal version 2.4 when running cabal init. #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

m-renaud
Copy link
Collaborator

@m-renaud m-renaud commented Mar 23, 2020

Cabal version 2.4 is over 2 years old at this point and has numerous additions
compared to the current default 1.10.

There are numerous references to the ^>= operator throughout the docs (nix-local-build.rst and developing-packages.rst) but this does not work in version 1.10. This results in unnecessary confusion for users which then must manually edit the cabal file to change the version. To add to the confusion, the format written to the cabal file (cabal-version: >=1.10) only works for this version, to use a newer version you need to remove the >= which is undocumented and confusing.

Lets just default to a more recent version.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

Cabal version 2.4 is over 2 years old at this point and has numerous additions
compared to the current default 1.10.
@m-renaud
Copy link
Collaborator Author

Hmm, not sure why one of the CI checks failed (was cancelled) :/ This PR should be safe to merge since it only changes a value within the cabal init command. @phadej should the CI be re-run (seems not useful) or can it just be merged in?

@m-renaud m-renaud merged commit 69030a4 into haskell:master Apr 1, 2020
@m-renaud m-renaud deleted the mrenaud-cabal-init-default-version branch April 1, 2020 04:37
@m-renaud m-renaud removed the request for review from phadej April 1, 2020 04:38
@phadej phadej mentioned this pull request Apr 1, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants