Skip to content

PoC: If import #5566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

PoC: If import #5566

merged 1 commit into from
Dec 4, 2018

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Sep 4, 2018 •
edited
Loading

This is very POC. more tests needed, docs, refactor (as it's hacked together now, somewhat ugly).

@phadej phadej mentioned this pull request Sep 4, 2018
Closed
@phadej phadej mentioned this pull request Nov 5, 2018
Closed
@phadej
Copy link
Collaborator Author

phadej commented Nov 24, 2018

This is ready to review (and merge)

@phadej
Copy link
Collaborator Author

phadej commented Nov 24, 2018

ping @hvr

haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
9a2e4c4 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"linux-7.8.4"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
8ccb08d 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"linux-7.6.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
aed0764 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"linux-7.10.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
55622ff 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"linux-8.0.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
24b06b8 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"linux-8.4.4"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
cf7279f 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"linux-8.2.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
18d1325 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"linux-8.6.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
c4657f2 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"linux-8.4.4-fdebug-expensive-assertions"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
7c6e468 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"osx-7.8.4"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
7ef83d9 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"osx-7.10.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 24, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
9a91d39 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "0392d136ff46c4d80297a3f62dacd04569b78a3d",
"tag":"osx-8.0.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 25, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
47379d5 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "f4ba42a73d459051603d1fb43818a6f31b727c07",
"tag":"linux-7.6.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 25, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
fe9a8de 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "f4ba42a73d459051603d1fb43818a6f31b727c07",
"tag":"linux-7.8.4"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 25, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
b39059e 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "f4ba42a73d459051603d1fb43818a6f31b727c07",
"tag":"linux-7.10.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 25, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
6528fb6 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "f4ba42a73d459051603d1fb43818a6f31b727c07",
"tag":"linux-8.0.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 25, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
7295a47 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "f4ba42a73d459051603d1fb43818a6f31b727c07",
"tag":"linux-8.6.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 25, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
d4bb65e 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "f4ba42a73d459051603d1fb43818a6f31b727c07",
"tag":"linux-8.4.4"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 25, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
1c284f9 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "f4ba42a73d459051603d1fb43818a6f31b727c07",
"tag":"linux-8.2.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 25, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
cf4f241 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "f4ba42a73d459051603d1fb43818a6f31b727c07",
"tag":"linux-8.4.4-fdebug-expensive-assertions"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 25, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
2d6db67 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "f4ba42a73d459051603d1fb43818a6f31b727c07",
"tag":"osx-7.8.4"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 25, 2018
@phadej
{"origin":"haskell/cabal/pull/5566",
82914aa 
"url":"pull/5566",
"account":"haskell",
"repo":"cabal",
"commit": "f4ba42a73d459051603d1fb43818a6f31b727c07",
"tag":"osx-8.0.2"
}
@phadej
Allow imports in conditional sections
a05db9b 
- Warn about missplaced import (on top level)
- Warn in trees
@phadej phadej merged commit ec6966e into haskell:master Dec 4, 2018
@phadej phadej deleted the if-import branch December 4, 2018 07:24
@eviefp eviefp mentioned this pull request Jun 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phadej