Skip to content

Minor refactor: spell out max supported GHC once #10663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Dec 22, 2024

This has been requested in the past: #8666 (comment)


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur
Copy link
Collaborator

Hm, how is this going to affect #10656, or vice versa since it's waiting to be merged?

@ulysses4ever
Copy link
Collaborator Author

Don't see a problem: I'll just rebase. Effectively this one subsumes #10656 but I don't want to go into trouble of getting people to agree on closing that one.

@ulysses4ever ulysses4ever added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Dec 23, 2024
@ulysses4ever
Copy link
Collaborator Author

@Kleidukos feel free to expedite if desired.

@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Dec 23, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@ulysses4ever
Copy link
Collaborator Author

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Dec 25, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@mergify mergify bot merged commit 3bbc15a into haskell:master Dec 25, 2024
49 checks passed
Kleidukos pushed a commit to Kleidukos/cabal that referenced this pull request Dec 26, 2024
* Minor refactor: spell out max supported GHC once

* fixup!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants