Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cabal-testsuite helpers #10388

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

9999years
Copy link
Collaborator

Needed for #10292.

The assertGlob family of helpers allow tests to assert that a glob matches at least one path (or alternatively, matches no paths). These are useful for matching temporary files, which can have arbitrary suffixes. The Glob package is used instead of Cabal's built-in glob-matching facility because Cabal's glob-matching logic doesn't allow wildcards in the middle of a filename, e.g. tmp-* or haddock-response*.txt.

The assert{Any,No}FileContains helpers allow tests to assert that at least one path in a list contains a given string (or alternatively, that no paths in a list contain a given string). These work nicely with lists of globs.

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Sep 28, 2024
@9999years 9999years added merge+no rebase merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days and removed merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Sep 30, 2024
@9999years
Copy link
Collaborator Author

Rebased manually to fix mergify (!)

@mergify mergify bot merged commit 4e194c6 into haskell:master Sep 30, 2024
47 checks passed
@9999years 9999years deleted the wiggles/testsuite-helpers branch September 30, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge merge+no rebase ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants