-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Mergify config for high priority PRs #10353
Conversation
9ebdbab
to
6c5a4d3
Compare
This won't interfere with our usual use of the priority label, because we either commit those directly or set the "merge delay passed" label (usually to fix CI breakage). It's only if we set the label and a merge label that it will come into play. If anything, it will make the latter case work better — but since CI is almost always broken in that case, there probably won't be anything to interrupt. |
6c5a4d3
to
04c628b
Compare
Added an extra priority rule to automatically bump merges directly to release branches (i.e. not backports) on the grounds that we're probably in a release cycle in that case. High priority PRs still override these. |
There's one more possible change to consider: if a PR has the "priority: high" label, automatically skip the cooldown period. That's a 3 line change to the code that adds the "merge delay passed" label, one of which is just a reindent. Note that you still have to set a merge label. |
Yeah, auto-skip for the delay did for cross my mind. Would be a cool improvement, I think. |
04c628b
to
2221350
Compare
As it is spoken…. |
2221350
to
513813e
Compare
This allows is to interrupt the merge queue for high priority PRs. It's using the "priority: high 🔥" label currently. Fixes: haskell#10352
513813e
to
350bf63
Compare
This allows us to interrupt the merge queue for high priority PRs. It's using the "priority: high 🔥" label currently.
Fixes: #10352
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR:
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).Mergify configuration is only read frommaster