New feature required to work around platform-specific source-repository-package issue #7083
Comments
5 tasks
iohk-bors bot
added a commit
to input-output-hk/iohk-monitoring-framework
that referenced
this issue
Sep 22, 2020
588: Fix build for MacOS r=deepfire a=newhoggy description ----------- See haskell/cabal#7083 for an explanation of why `source-repository-package` stanzas that reference packages on a specific platform causes problems for platforms where the package doesn't build. checklist --------- - [x] compiles (`cabal v2-build` or `stack build`) - [x] tests run successfully (`cabal v2-test` or `stack test`) - [ ] documentation added - [ ] link to an issue - [ ] add milestone (the current sprint) Co-authored-by: John Ky <john.ky@iohk.io>
georgefst
added a commit
to georgefst/monpad
that referenced
this issue
Jan 2, 2022
…on Windows This is necessary due to haskell/cabal#7083. I'm not actually sure why `rawfilepath` isn't building on Windows (with GHC 9.2), but seeing as I already have one unaddressed PR there, I don't really want to investigate further. And `rawfilepath` is only a dependency via `unix`, which obviously shouldn't be built on Windows.
|
I've just hit this, as you can see above. I guess ideally it would be closed via #5444? |
|
Yeah, looks like the same exact issue in fact. Can we close this one as a dup? |
|
ok lets just note this will be resolved by #7783 |
|
...and as #7783 adding conditionals to cabal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Sometimes we have the situation where a package we depend only builds on a specific platform. For example
libsystemd-journalonly builds on Linux. We canif os(linux)in the cabal file, so that much is fine, but let's say the package has a bug in it and we want to fork it and used the fork until the bug is upstreamed. This does not work becausesource-repository-packageadds the project to the list of local packages to always build, socabal allno longer works, which breaks CI.To Reproduce
Described above.
Expected behavior
This could be fixed in a number of ways. Add support for
ifincabal.projectwould allow us to conditionally addsource-repository-package. Or we could makesource-repository-packagenot add to the list of local projects to build.System information
Affects all versions of cabal currently.
Additional context
Work arounds include using
allow-newer, for exampleallow-newer: libsystemd-journal:baseif the problem is just a version bound adjustment.But this does not solve the problem if the problem preventing the build from succeeding is not a bounds issue.
The text was updated successfully, but these errors were encountered: