Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal check doesn't detect using invalid version syntax for spec versions prior to 1.24 #5092

Open
hvr opened this issue Feb 1, 2018 · 1 comment

Comments

@hvr
Copy link
Member

hvr commented Feb 1, 2018

This already caused 4 incidents in the package index (see haskell-infra/hackage-trustees#128)

@phadej found the culprit at 6b3457d which relaxed the Version parser to accommodate parsing pkg-config output (which imho deserves its own version parsing anyway), and as an overlooked side-effect also relaxed the parsing of the cabal format.

@hvr hvr added this to the 2.2 milestone Feb 1, 2018
@23Skidoo
Copy link
Member

23Skidoo commented Feb 1, 2018

+1 on having a PkgConfigVersion type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants