CI: Tweaks

* Update ghc versions used.
* Disable huge number of failing test for ghc == 9.4.* on Windows.

Author: erikd

.github/workflows/validate.yml

@@ -38,7 +38,7 @@ jobs:
     strategy:
       matrix:
         os: ["ubuntu-latest", "macos-latest", "windows-latest"]
-        ghc: ["9.6.3", "9.4.7", "9.2.8", "9.0.2", "8.10.7", "8.8.4", "8.6.5", "8.4.4"]
+        ghc: ["9.6.3", "9.4.7", "9.2.7", "9.0.2", "8.10.7", "8.8.4", "8.6.5", "8.4.4"]
         exclude:
           # corrupts GHA cache or the fabric of reality itself, see https://github.com/haskell/cabal/issues/8356
           - os: "windows-latest"

cabal-testsuite/PackageTests/Ambiguity/setup-package-import.test.hs

@@ -3,6 +3,9 @@ import Test.Cabal.Prelude
 -- qualified imports.  (Paper Backpack doesn't natively support
 -- this but we must!)
 main = setupAndCabalTest $ do
+  isWin <- isWindows
+  ghc94 <- isGhcVersion "== 9.4.*"
+  expectBrokenIf (isWin && ghc94) 9414 $
     withPackageDb $ do
         withDirectory "p" $ setup_install []
         withDirectory "q" $ setup_install []

cabal-testsuite/PackageTests/Ambiguity/setup-reexport.test.hs

@@ -2,8 +2,11 @@ import Test.Cabal.Prelude
 -- Test that we can resolve a module name ambiguity when reexporting
 -- by explicitly specifying what package we want.
 main = setupAndCabalTest $ do
-    skipUnlessGhcVersion ">= 7.9"
-    withPackageDb $ do
+    isWin <- isWindows
+    ghc94 <- isGhcVersion "== 9.4.*"
+    expectBrokenIf (isWin && ghc94) 9414 $ do
+      skipUnlessGhcVersion ">= 7.9"
+      withPackageDb $ do
         withDirectory "p" $ setup_install []
         withDirectory "q" $ setup_install []
         withDirectory "reexport" $ setup_install []

cabal-testsuite/PackageTests/Backpack/Includes2/setup-internal.test.hs

@@ -1,5 +1,8 @@
 import Test.Cabal.Prelude
 main = setupAndCabalTest $ do
+  isWin <- isWindows
+  ghc94 <- isGhcVersion "== 9.4.*"
+  expectBrokenIf (isWin && ghc94) 9414 $ do
     skipUnlessGhcVersion ">= 8.1"
     withPackageDb $ do
         setup_install ["--cabal-file", "Includes2.cabal"]

cabal-testsuite/PackageTests/Backpack/Includes3/setup-internal.test.hs

@@ -1,5 +1,8 @@
 import Test.Cabal.Prelude
 main = setupAndCabalTest $ do
+  isWin <- isWindows
+  ghc94 <- isGhcVersion "== 9.4.*"
+  expectBrokenIf (isWin && ghc94) 9414 $ do
     skipUnlessGhcVersion ">= 8.1"
     withPackageDb $ do
       setup_install []

cabal-testsuite/PackageTests/Backpack/Includes4/setup.test.hs

@@ -1,5 +1,8 @@
 import Test.Cabal.Prelude
 main = setupAndCabalTest $ do
+  isWin <- isWindows
+  ghc94 <- isGhcVersion "== 9.4.*"
+  expectBrokenIf (isWin && ghc94) 9414 $ do
     skipUnlessGhcVersion ">= 8.1"
     withPackageDb $ do
       setup_install []

cabal-testsuite/PackageTests/Backpack/Includes5/setup.test.hs

@@ -1,5 +1,8 @@
 import Test.Cabal.Prelude
 main = setupAndCabalTest $ do
+  isWin <- isWindows
+  ghc94 <- isGhcVersion "== 9.4.*"
+  expectBrokenIf (isWin && ghc94) 9414 $ do
     skipUnlessGhcVersion ">= 8.1"
     setup "configure" []
     r <- fails $ setup' "build" []

cabal-testsuite/PackageTests/Backpack/Reexport1/setup.test.hs

@@ -1,6 +1,9 @@
 import Test.Cabal.Prelude
 main = setupAndCabalTest $ do
-    skipUnlessGhcVersion ">= 8.1"
+  skipUnlessGhcVersion ">= 8.1"
+  isWin <- isWindows
+  ghc94 <- isGhcVersion "== 9.4.*"
+  expectBrokenIf (isWin && ghc94) 9414 $
     withPackageDb $ do
       withDirectory "p" $ setup_install_with_docs []
       withDirectory "q" $ do

cabal-testsuite/PackageTests/Backpack/T4754/setup.test.hs

@@ -1,6 +1,9 @@
 import Test.Cabal.Prelude
 main = setupAndCabalTest $ do
-    skipUnlessGhcVersion ">= 8.1"
+  skipUnlessGhcVersion ">= 8.1"
+  isWin <- isWindows
+  ghc94 <- isGhcVersion "== 9.4.*"
+  expectBrokenIf (isWin && ghc94) 9414 $ do
     skipUnless "no profiling libs" =<< hasProfiledLibraries
     setup "configure" ["--enable-profiling"]
     setup "build" []

cabal-testsuite/PackageTests/Backpack/T5634/setup.test.hs

@@ -1,5 +1,8 @@
 import Test.Cabal.Prelude
 main = setupAndCabalTest $ do
-    skipUnlessGhcVersion ">= 8.1"
+  skipUnlessGhcVersion ">= 8.1"
+  isWin <- isWindows
+  ghc94 <- isGhcVersion "== 9.4.*"
+  expectBrokenIf (isWin && ghc94) 9414 $ do
     setup "configure" []
     setup "build" []