Skip to content

Commit 7b1a693

Browse files
Do not always pass --quickjump to haddock (#9049)
1 parent 1723d22 commit 7b1a693

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

Cabal/src/Distribution/Simple/Haddock.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -867,7 +867,7 @@ renderPureArgs version comp platform args =
867867
$ args
868868
else []
869869
, ["--since-qual=external" | isVersion 2 20]
870-
, [ "--quickjump" | isVersion 2 19, _ <- flagToList . argQuickJump $ args
870+
, [ "--quickjump" | isVersion 2 19, True <- flagToList . argQuickJump $ args
871871
]
872872
, [ "--hyperlinked-source" | isVersion 2 17, True <- flagToList . argLinkedSource $ args
873873
]

changelog.d/pr-9049

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
synopsis: Do not always pass --quickjump to haddock #9049
2+
packages: Cabal
3+
prs: #9049
4+
issues: #9060
5+
description: {
6+
7+
6d8adf13101 caused `cabal` to always pass the `--quickjump` flag to Haddock.
8+
Not only does this waste memory for a service that user hasn't asked for,
9+
but also leads to a failure with Haddocks shipped with GHC 9.0 and 9.2,
10+
which had a separate bug (fixed in later versions but not backported) when
11+
Haddock does not pass `--quickjump` recursively to the package dependencies.
12+
13+
}

0 commit comments

Comments
 (0)