Change equational constraints on IsString (Parser a)
to a ~ ()
#229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I just got this wrong when I originally implemented this (888b7d7, 0265427).
When you parse a constant string it is not really useful to inspect the parse result. For that reason I think it is justified to change the type from
Parser Text
toParser ()
.This doesn't make a difference for applicative-style code, but it helps with monadic code, making it
-Wall
sane, e.g. you can now sayinstead of
Technically this is a breaking change, but I have a hard time to imagine non-contrived code that would break from this.