Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ fix ] typo in error message #1081

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[ fix ] typo in error message #1081

wants to merge 3 commits into from

Conversation

gallais
Copy link

@gallais gallais commented Oct 24, 2023

No description provided.

phadej
phadej requested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same type is also in ByteString and Lazy variants. Do you mind fixing them as well? And also run cabal run aeson-tests -- --accept to accept the changed golden files.

@gallais
Copy link
Author

gallais commented Oct 25, 2023 •
edited
Loading

I've pushed the additional fixes. I am however unable to run the cabal command:

Edit: nevermind, I just needed to cabal update.
I'll hopefully be able to push the updated golden files soon.

@phadej phadej self-assigned this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phadej phadej phadej requested changes

Assignees

@phadej phadej

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gallais @phadej