Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper encoding of reserved characters #83

Open
ttuegel opened this issue Apr 23, 2015 · 1 comment
Open

Improper encoding of reserved characters #83

ttuegel opened this issue Apr 23, 2015 · 1 comment

Comments

@ttuegel
Copy link
Member

ttuegel commented Apr 23, 2015

This was originally reported as a Cabal bug, but I believe it belongs here:

The value of HTTP_PROXY has as format
http://user:pass@host:80/

In the password special characters can occur, like @ and !.
According to wiki (http://en.wikipedia.org/wiki/Percent-escape)
these characters must be percent-encoded, like %40 and %21.

Cabal doesn't accept percent-encoded characters.
And cabal errs on these characters (if password is a@b, Cabal doesn't look to the right site, but >probably to "b@host:80" (error message is not clear enough to be certain)

@hsenag
Copy link
Member

hsenag commented Apr 24, 2015

Sounds plausible - if you can supply a fix that'd be great, otherwise I'll take a look but no guarantees as to when I'm afraid.

It'd be nice to have a test but I don't see any Haskell HTTP proxies that support authentication around so that's probably not feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants