Skip to content

Export encoding function for a query parameter value #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

marinelli
Copy link
Contributor

After the refactoring of URL encoding (#1432), the type of the appendToQueryString function has changed.
It might be helpful to export the function encodeQueryParamValue (it was encodeQueryParam) that could be used to obtain the proper value to pass to appendToQueryString, when this function is used outside of servant.

This PR proposes to:

  • move encodeQueryParam from Servant.Client.Core.HasClient to Servant.Client.Core.Request
  • rename encodeQueryParam into encodeQueryParamValue, just to be more explicit
  • re-export encodeQueryParamValue from Servant.Client.Core
  • add short descriptions to some of the exported functions of the Servant.Client.Core.Request module

@tchoutri tchoutri merged commit d05da71 into haskell-servant:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants