Export encoding function for a query parameter value #1549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the refactoring of URL encoding (#1432), the type of the
appendToQueryString
function has changed.It might be helpful to export the function
encodeQueryParamValue
(it wasencodeQueryParam
) that could be used to obtain the proper value to pass toappendToQueryString
, when this function is used outside ofservant
.This PR proposes to:
encodeQueryParam
fromServant.Client.Core.HasClient
toServant.Client.Core.Request
encodeQueryParam
intoencodeQueryParamValue
, just to be more explicitencodeQueryParamValue
fromServant.Client.Core
Servant.Client.Core.Request
module