Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

maximum & minimum is implemented through a list #299

Open
@vincenthz

Description

@vincenthz

Implementation of maximum & minimum is not optimal at all and used a list for most types:

instance Collection (BA.Array ty) where
    ...
    minimum = Data.List.minimum . toList . getNonEmpty -- TODO
    ...

types having a bad implementation:

  • Block
  • UArray
  • Array
  • String
  • Bitmap
  • ChunkedUArray

Metadata

Metadata

Assignees

No one assigned

    Labels

    C - performanceperformance relatedD - easyDifficulty easy for beginnersT - arrayaffect type ArraysT - bitmapaffect type BitmapsT - stringAffect type Strings

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions