Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okta Dep Update #28121

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Okta Dep Update #28121

wants to merge 4 commits into from

Conversation

kpcraig
Copy link
Contributor

@kpcraig kpcraig commented Aug 19, 2024

Description

This PR updates our Okta SDK dependency to v4, so that we transitively remove a go-jose dependency CVE-2024-28180. (Old versions of go-jose are pulled in other places as well and tracked in the issue named by the branch; this seems to be the only one that requires code changes on our part.)

Unfortunately, to get rid of the <=v2.6.2 vulerability, we had to move the okta-sdk to at least v3, which causes these breaking changes below. There didn't appear to be additional (relevant) changes between v3 and v4, so I moved to v4 directly.

This version is still broken (hence, draft); I put it here so I can link it in various sustaining channels/threads.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 19, 2024
Copy link

github-actions bot commented Aug 19, 2024

CI Results: failed ❌
Failures:

Test Type Package Test Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant