UI: remove current_billing_period from dashboard activity log request
#27559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
changed the title
current_billing_period from dashboard activity log request
|
CI Results: |
|
Build Results: |
hellobontempo
deleted the
ui/VAULT-28312/remove-current_billing_period-from-dashboar
branch
hashishaw
added a commit
that referenced
this pull request
Sep 17, 2024
…st (#27559) * remove current_billing_period from dashboard request * add changelog * remove timestamp from assertion * update mirage
hashishaw
added a commit
that referenced
this pull request
Sep 17, 2024
* Hide flash warning on dashboard from client count activity endpoint * UI: remove `current_billing_period` from dashboard activity log request (#27559) * remove current_billing_period from dashboard request * add changelog * remove timestamp from assertion * update mirage * fix chroot test error 'must setup rendering context before attempting to interact with elements' * stabilize chroot test
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
sys/internal/counters/activityresponse now defaults to use the license start time to the current month as start and end time params (previously thestart_timewas the current month minus one year andend_timewas the month before current. For example, if it's currently June 2024, the data returned would be from June 2023-May 2024.)As a result,
current_billing_periodis now deprecated so we can remove this query param from the dashboard request to the activity log.✅ enterprise tests