Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: show banner when batch token expired #26396

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Apr 12, 2024

Previously, when logging in with a batch type token the UI would suddenly stop working with a permissions error when the batch token expires. This PR allows the UI to know when the batch token will expire and show the token expired warning when it does.

Testing steps

  • Create a batch token with a short TTL vault token create -type=batch -ttl=30s
  • Log into the GUI with the returned token
  • Wait for the TTL amount of time
  • See that the GUI shows the same token expired banner as when a service type token expires

Before and after
GUI before (left) and after (right)

batch-expire

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.14.x labels Apr 12, 2024
@hashishaw hashishaw added this to the 1.14.12 milestone Apr 12, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 12, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Apr 12, 2024

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work as always on these tricky workflows! Tested and it works as expected.

@hashishaw hashishaw merged commit 51ee69d into main Apr 15, 2024
31 checks passed
@hashishaw hashishaw deleted the ui/VAULT-24873/batch-token-expiry-banner branch April 15, 2024 21:04
hashishaw added a commit that referenced this pull request Apr 15, 2024
* allow token expiry for batch token

* add changelog
hashishaw added a commit that referenced this pull request Apr 15, 2024
* allow token expiry for batch token

* add changelog
hashishaw added a commit that referenced this pull request Apr 16, 2024
* allow token expiry for batch token

* add changelog
hashishaw added a commit that referenced this pull request Apr 16, 2024
* allow token expiry for batch token

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants