Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark X509v3 Subject Alternative Name extension as critical #26064

Open
TomerHakim opened this issue Mar 20, 2024 · 0 comments
Open

Mark X509v3 Subject Alternative Name extension as critical #26064

TomerHakim opened this issue Mar 20, 2024 · 0 comments

Comments

@TomerHakim
Copy link

Is your feature request related to a problem? Please describe.
There is no way to mark the X509v3 Subject Alternative Name as critical in Vault (for certificates and intermediate CAs).

Describe the solution you'd like
Add an option to mark the X509v3 Subject Alternative Name as critical, also when using curl API to generate the certificate/intermediate CA.

Describe alternatives you've considered
Didn't find any alternative with using vault pki engine.

Explain any additional use-cases
A very similar case is this: #9779
The above case is just another extension

Additional context
I think it's worth having all extensions configurable as critical/non-critical (non critical can be the default for backward compatibility). It can add much needed flexibility when creating certificates and it will be very convenient when having scenarios where replacing old certificates, that were created by other tools, to new certificates that must be created using vault and must include specific extensions configured in specific manner.

in my example, I need the Subject Alternative Name extension to change from this:

            X509v3 Subject Alternative Name:
                DNS:example.com

to this:

            X509v3 Subject Alternative Name: critical
                DNS:example.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants