Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKI Role Case Sensitity Declaration for Config Parameters #25865

Open
danielhass opened this issue Mar 11, 2024 · 0 comments
Open

PKI Role Case Sensitity Declaration for Config Parameters #25865

danielhass opened this issue Mar 11, 2024 · 0 comments

Comments

@danielhass
Copy link

Is your feature request related to a problem? Please describe.
We were unsure about the case-sensitivity of several domain related parameters for PKI roles in Vault.

These are documented here: https://developer.hashicorp.com/vault/api-docs/secret/pki#create-update-role

E.g. in case of the parameter allowed_domains we were not sure if the values entered are normalized in some way (as they are DNS names) or if they are case-sensitive during evaluation within Vault. We found that they are indeed case-sensitive. This is not explicitly stated in the docs.

However some parameters state explicitly that they are not case-sensitive, e.g.: https://developer.hashicorp.com/vault/api-docs/secret/pki#key_usage-1 - but in the whole docs page there is not statement given that per default values are case-sensitive and the exception is marked accordingly.

Describe the solution you'd like
I would like to see either a general statement that config parameters are case-sensitive and exceptions are marked accordingly. Or the case-sensitivity of the option should be stated explicitly (however this would hurt readability probably).

Additional context
If I'm missing some statement in docs docs clarifying please point that out. Otherwise I'm also willing to provide a PR for whatever variant the Vault teams sees a better fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants