Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Setting Vault Namespace through Annotation #55

Closed
malnick opened this issue Jan 23, 2020 · 1 comment
Closed

Allow Setting Vault Namespace through Annotation #55

malnick opened this issue Jan 23, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request injector Area: mutating webhook service
Milestone

Comments

@malnick
Copy link

malnick commented Jan 23, 2020

In order to set a namespace today, you need to do so through the secret annotation setting:

{{- with secret "`ns1/ns2/secret/foo" -}}
        {{.Data.password}}
{{- end }}

Consider adding an annotation that does this explicitly for the agent for overriding VAULT_NAMESPACE such as:

vault.hashicorp.com/namespace: "ns1"

Then you would only need to write {{- with secret "secret/foo" -}} and ns1 would be added to the path.

@malnick malnick self-assigned this Jan 23, 2020
@malnick malnick added enhancement New feature or request injector Area: mutating webhook service labels Jan 23, 2020
@malnick malnick added this to the 0.2.0 milestone Jan 23, 2020
@malnick
Copy link
Author

malnick commented Jan 23, 2020

Duplicate of #20

@malnick malnick marked this as a duplicate of #20 Jan 23, 2020
@malnick malnick closed this as completed Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request injector Area: mutating webhook service
Projects
None yet
Development

No branches or pull requests

1 participant