Set let require_unimplemented_servers default to true when generating code from .proto files #37737
+57
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
…ode from proto files. Run `make protobuf`. This allows require_unimplemented_servers to default to true, and the generated code shows the impacts of that.
…and skip generating code for the `mustEmbedUnimplementedFoobarServer` method that is implemented via that embedding.
SarahFrench
force-pushed
the
sarah/set-require_unimplemented_servers=true
branch
from
6967215 to
44d76a4
Compare
dbanck
approved these changes
Oct 8, 2025
Member
Author
|
Thanks! |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37699
This PR removes the require_unimplemented_servers=false option that's passed to
protocwhen generating code.That change requires Server structs to embed an UnimplemntedFoobarServer struct that's generated by protoc-gen-go-grpc, so this PR manually updates struct to embed the correct 'unimplemented' struct and updates generators to generate code that includes the required embedding.
Target Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry