undeclared variables must be allowed during apply #36025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
added
the
1.10-backport
DanielMSchmidt
approved these changes
Nov 18, 2024
Plan allows undeclared config variables with only warnings, and that behavior need to be carried forward to apply now that ephemeral variables can be passed in at apply time.
jbardin
force-pushed
the
jbardin/undeclared-vars
branch
from
08cec0b to
c1f8152
Compare
bschaatsbergen
approved these changes
Nov 18, 2024
|
The equivalence tests will be updated. Please verify the changes here. |
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan allows undeclared config variables with only warnings, and that behavior needs to be carried forward to apply now that ephemeral variables can be passed in at apply time. We still want to preserve the same semantics as plan, which handle environment, file and cli variables differently, so this re-uses the same plan-time parsing logic.
Fixes #36017