Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming terraform workspace new command to terraform workspace create #35790

Closed
wants to merge 2 commits into from

Conversation

twalker1998
Copy link

Renaming terraform workspace new to terraform workspace create to ensure subcommands for terraform workspace are all the same part of speech

Fixes #35789

Target Release

This will likely constitute a breaking change

Draft CHANGELOG entry

ENHANCEMENTS

Ensuring all terraform workspace subcommands are the same part of speech

  • Users creating a new workspace via the Terraform CLI should use terraform workspace create instead of terraform workspace new

Copy link

hashicorp-cla-app bot commented Sep 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@twalker1998
Copy link
Author

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

I've signed the CLA, as evidenced by #35790 (comment)

@crw
Copy link
Collaborator

crw commented Oct 1, 2024

Thanks for this submission. At triage the maintainers decided not to accept this change, and also would not be willing to accept the alternative of an alias, to keep the surface area for this feature as minimal as possible. Thanks for this submission, we appreciate the feedback and effort!

Copy link

github-actions bot commented Nov 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform workspace commands aren't all verbs
2 participants