Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertex_ai: add support for private_service_connect_config in google_vertex_ai_endpoint #19413

Open
axtma opened this issue Sep 9, 2024 · 5 comments

Comments

@axtma
Copy link

axtma commented Sep 9, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

I am trying to use the resource for Vertex AI endpoint which says Only one of the fields, network or enable_private_service_connect, can be set.. However, when I set enable_private_service_connect as true in my Terraform config, I get an error as An argument named "enable_private_service_connect" is not expected here.

Terraform Version & Provider Version(s)

Terraform vX.X.X
on

  • provider registry.terraform.io/hashicorp/google vX.X.X
  • provider registry.terraform.io/hashicorp/google-beta vX.X.X

Terraform v1.7.4
on darwin_arm64

  • provider registry.terraform.io/hashicorp/google v6.1.0

Your version of Terraform is out of date! The latest version
is 1.9.5. You can update by downloading from https://www.terraform.io/downloads.html

Affected Resource(s)

google_vertex_ai_endpoint

Terraform Configuration

Debug Output

No response

Expected Behavior

No response

Actual Behavior

No response

Steps to reproduce

  1. terraform apply

Important Factoids

No response

References

No response

b/368589149

@axtma axtma added the bug label Sep 9, 2024
@github-actions github-actions bot added forward/review In review; remove label to forward service/aiplatform-prediction labels Sep 9, 2024
@ggtisc ggtisc self-assigned this Sep 12, 2024
@ggtisc
Copy link
Collaborator

ggtisc commented Sep 12, 2024

Hi @axtma!

Please share your terraform code to replicate this issue. In terraform registry I see this argument relate to the enable_private_service_connect. Is this terraform configuration ok?

@Filipo24
Copy link

The terraform resource documentation needs an update and remove the statement of "Only one of the fields, network or enable_private_service_connect, can be set." as its misleading, since there isn't another argument reference named enable_private_service_connect in the resource specification.

I believe that is primarily due to the fact that as per the Vertex AI Endpoint API documentation the enablePrivateServiceConnect field is classed as deprecated.

To support Private Service Connect for Vertex AI endpoints field privateServiceConnectConfig needs to be set - this most likely requires a feature enhancement for the Vertex AI Endpoint resource to support a new argument

private_service_connect_config {
enable_private_service_connect = true
project_allow_list = ["project_1"]
}.

@ggtisc
Copy link
Collaborator

ggtisc commented Sep 19, 2024

@axtma is the @Filipo24 comment related to your issue? I need more information to replicate this issue. Still waiting for the

  1. terraform code
  2. debug output
  3. expected behavior
  4. actual behavior

@axtma
Copy link
Author

axtma commented Sep 20, 2024

Yes, that's exactly what I was trying to point out.

TF code could be something like :

resource "google_vertex_ai_endpoint" "endpoint" {
  name         = "endpoint-name"
  display_name = "sample-endpoint"
  description  = "A sample vertex endpoint"
  location     = "us-central1"
  region       = "us-central1"
  labels       = {
    label-one = "value-one"
  }
  enable_private_service_connect = true
}

While the error was that enable_private_service_connect field isn't expected here likely because it isn't supported by the resource as of now but somehow is present in the documentation.

@ggtisc
Copy link
Collaborator

ggtisc commented Sep 20, 2024

Confirmed documentation issue!

In terraform registry is mentioned the enable_private_service_connect in the network argument, but it doesn't appear as an argument and when trying to use it the following message is displayed:

Unexpected attribute: An attribute named "enable_private_service_connect" is not expected here

@ggtisc ggtisc removed the forward/review In review; remove label to forward label Sep 20, 2024
@ggtisc ggtisc removed their assignment Sep 20, 2024
@BBBmau BBBmau changed the title enable_private_service_connect not working vertex_ai: add support for private_service_connect_config in google_vertex_ai_endpoint Sep 23, 2024
@BBBmau BBBmau added the size/s label Sep 23, 2024
@BBBmau BBBmau added this to the Goals milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants