Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add IAM condition fields to IAM resources if the API supports IAM conditions #18412

Open
melinath opened this issue Jun 12, 2024 · 1 comment
Labels
breaking-change mmv1-generator Provider-wide changes to resource templates or other generator changes service/terraform size/xl technical-debt

Comments

@melinath
Copy link
Collaborator

What kind of contribution is this issue about?

MMv1-based resource

Details

Currently, all IAM resources have condition fields - but they are undocumented & untested by default and may cause unexpected behavior if used, unless the API actually supports conditions. We should only add those fields in cases where we believe that conditions are supported. Currently this is indicated by the presence of iam_policy.iam_conditions_request_type - we could potentially consider adding an explicit indicator of supported vs not.

This would be a breaking change because it would remove fields from the resources.

References

#18215 (comment)

@melinath melinath added breaking-change technical-debt mmv1-generator Provider-wide changes to resource templates or other generator changes labels Jun 12, 2024
@melinath melinath added this to the Future Major Release milestone Jun 17, 2024
@melinath
Copy link
Collaborator Author

Note from triage: We could probably do an initial version of this that isn't a breaking change; leaving in "future major release" so we can consider it as a project at that point, since the non-breaking change would be prep for the breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change mmv1-generator Provider-wide changes to resource templates or other generator changes service/terraform size/xl technical-debt
Projects
None yet
Development

No branches or pull requests

1 participant