-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_system_center_virtual_machine_manager_virtual_machine_instance
#27622
base: main
Are you sure you want to change the base?
New Resource: azurerm_system_center_virtual_machine_manager_virtual_machine_instance
#27622
Conversation
…machinemanagervirtualmachineinstance
…machinemanagervirtualmachineinstance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @neil-yechenwei ,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍
...ualmachinemanager/system_center_virtual_machine_manager_virtual_machine_instance_resource.go
Show resolved
Hide resolved
...ualmachinemanager/system_center_virtual_machine_manager_virtual_machine_instance_resource.go
Show resolved
Hide resolved
...ualmachinemanager/system_center_virtual_machine_manager_virtual_machine_instance_resource.go
Outdated
Show resolved
Hide resolved
...ualmachinemanager/system_center_virtual_machine_manager_virtual_machine_instance_resource.go
Outdated
Show resolved
Hide resolved
...ualmachinemanager/system_center_virtual_machine_manager_virtual_machine_instance_resource.go
Outdated
Show resolved
Hide resolved
...chinemanager/system_center_virtual_machine_manager_virtual_machine_instance_resource_test.go
Show resolved
Hide resolved
website/docs/r/system_center_virtual_machine_manager_virtual_machine_instance.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/system_center_virtual_machine_manager_virtual_machine_instance.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/system_center_virtual_machine_manager_virtual_machine_instance.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/system_center_virtual_machine_manager_virtual_machine_instance.html.markdown
Outdated
Show resolved
Hide resolved
24f425f
to
9d7a3b3
Compare
@ms-zhenhua , thanks for the comments. Please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @neil-yechenwei ,
Thank you for your updates. LGTM~
Hi @rcskosir Requesting review of this PR so that we are able to complete our support for our RP on Terraform. |
Community Note
Description
This PR is to support System Center Virtual Machine Manager Virtual Machine Instance.
API reference: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/scvmm/resource-manager/Microsoft.ScVmm/stable/2023-10-07/scvmm.json
Overview: https://learn.microsoft.com/en-us/azure/azure-arc/system-center-virtual-machine-manager/overview
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_system_center_virtual_machine_manager_virtual_machine_instance
This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.