New Resource: azurerm_system_center_virtual_machine_manager_virtual_machine_instance

[neil-yechenwei]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support System Center Virtual Machine Manager Virtual Machine Instance.

API reference: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/scvmm/resource-manager/Microsoft.ScVmm/stable/2023-10-07/scvmm.json

Overview: https://learn.microsoft.com/en-us/azure/azure-arc/system-center-virtual-machine-manager/overview

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/basic (764.98s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/requiresImport (840.68s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/complete (825.70s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/update (934.30s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/inventoryItemId (330.69s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• New Resource: azurerm_system_center_virtual_machine_manager_virtual_machine_instance

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[ms-zhenhua]

Hi @neil-yechenwei ,

Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

[neil-yechenwei]

@ms-zhenhua , thanks for the comments. Please take another look.

[ms-zhenhua]

Hi @neil-yechenwei ,

Thank you for your updates. LGTM~

[sidsinghms]

Hi @rcskosir
With this PR we are adding the VirtualMachineInstance resource.
We had earlier added other resources, for our RP Azure Arc enabled SCVMM.

Requesting review of this PR so that we are able to complete our support for our RP on Terraform.
Several customers are lined up, waiting for Terraform support for quite some time now. We have a good opportunity to drive adoption from some of the S500 customers to our service. One of our major customers, NVIDIA, is currently blocked without Terraform support.