Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_managed_storage_account - fix TestAccKeyVaultManagedStorageAccount_* #23022

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

liuwuliuyun
Copy link
Contributor

@liuwuliuyun liuwuliuyun commented Aug 21, 2023

This issue is introduced by #22915

Fix TestAccKeyVaultManagedStorageAccount* all of them are failing now.

Root cause: The id needs to be set here is a managed storage account id with format looks like "https://acctestkv-rxfqz.vault.azure.net/storage/acctestKVstorage", not common StorageAccountId.

Fix method: Update the parsing function for two resources when creating and add .ID function for sasToken.

After this fix, all tests besides TestAccKeyVaultManagedStorageAccountSasTokenDefinition_recovery should works. Will track that one in a diff PR.

@liuwuliuyun
Copy link
Contributor Author

This seems to block by lagacy functions detection, needs to figure out a different way to address this.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment that I'm going to push a commit for, but this otherwise LGTM 👍

internal/services/keyvault/parse/sas_definition.go Outdated Show resolved Hide resolved
@mbfrahry mbfrahry merged commit 0b5ab33 into hashicorp:main Sep 7, 2023
21 checks passed
mbfrahry added a commit that referenced this pull request Sep 7, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants