Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling: upgrade golangci-lint to v1.41.1 #12903

Merged
merged 5 commits into from
Aug 9, 2021
Merged

Conversation

jackofallops
Copy link
Member

Includes:

  • workaround for staticcheck lint directives not working correctly
  • Lint fixes for new rules in existing linters since 1.32
  • fixes the exclude path for filtering out the generated SDK folders in the service packages

Purposely Excludes:

  • whitespace linter for performance reasons (skips cache on change and takes a long time due to number of files in the repo
  • New linters introduced since 1.32 to reduce potential problems of change-on-change
  • dropping the timeout value until proven to execute sufficiently faster than previously in GHA

Note: contributors will need to re-run make tools to pick up the new version and correctly lint for the additional rules covered.

@jackofallops jackofallops added this to the v2.72.0 milestone Aug 9, 2021
@jackofallops jackofallops requested a review from a team August 9, 2021 09:09
@github-actions github-actions bot added the size/M label Aug 9, 2021
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⏩

@jackofallops jackofallops merged commit c9bf6e3 into main Aug 9, 2021
@jackofallops jackofallops deleted the gha/linter-upgrade branch August 9, 2021 09:50
@github-actions
Copy link

This functionality has been released in v2.72.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants