Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DDOS IP Protection for azurerm_public_ip resource #27658

Open
1 task done
vtapadia opened this issue Oct 15, 2024 · 2 comments
Open
1 task done

Support for DDOS IP Protection for azurerm_public_ip resource #27658

vtapadia opened this issue Oct 15, 2024 · 2 comments

Comments

@vtapadia
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

The current field

ddos_protection_mode - (Optional) The DDoS protection mode of the public IP. Possible values are Disabled, Enabled, and VirtualNetworkInherited. Defaults to VirtualNetworkInherited.

But the public IP also supports IP Protection which should be supported by the resource.

New or Affected Resource(s)/Data Source(s)

azurerm_public_ip

Potential Terraform Configuration

ddos_protection_mode = "IPProtection"

References

No response

@ziyeqf
Copy link
Contributor

ziyeqf commented Oct 16, 2024

Hi @vtapadia ,thanks or opening the issue.

Just checked on the Portal, setting this value to enabled will enable the IP protection. It's extactly as same as enabling "IPProection" on portal.

@vtapadia
Copy link
Author

I think in the latest changes, maybe this is no more reported as different. When I opened the issue, it was reporting as different.
The enabled I thought was related to providing a plan_id linked to it.

For now, it was not working so when it is disabled and we run with enabled, nothing happens. But when we change manually, and then run with "Enabled" it is no more reported as different as well. So for now it is ok, but I think it would be better if this is supported with a specific value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants