Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Updates in azurerm_container_app_custom_domain #27148

Open
1 task done
michael-sterling opened this issue Aug 22, 2024 · 0 comments
Open
1 task done

Support Updates in azurerm_container_app_custom_domain #27148

michael-sterling opened this issue Aug 22, 2024 · 0 comments

Comments

@michael-sterling
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

Updating the container_app_environment_certificate_id property on the azurerm_container_app_custom_domain resource should not require deleting and re-creating the custom domain.

Currently, because container_app_environment_certificate_id is marked ForceNew1, updating that property in Terraform causes the provider to delete and re-create the entire custom domain for the Container App. This results in downtime for the domain after it is deleted but before it is re-created.

However, this is not necessary; updating the Certificate ID for a Custom Domain using the Azure REST API directly does not cause downtime.

Likely this property was marked ForceNew because the resource currently has no Update() method, and marks all properties ForceNew to use Delete() and Create() to "simulate" an update. The current implementation of Delete()2 should be a reasonable template to implement Update-in-place logic.

New or Affected Resource(s)/Data Source(s)

azurerm_container_app_custom_domain

Potential Terraform Configuration

No response

References

Footnotes

  1. container_app_environment_certificate_id is marked as ForceNew: true, here

  2. Current Delete implementation updating just one Custom Domain in a Container App

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants