Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Container Registry Credential Set #26539

Open
1 task done
OmarHawk opened this issue Jul 4, 2024 · 1 comment · May be fixed by #27528
Open
1 task done

Support for Container Registry Credential Set #26539

OmarHawk opened this issue Jul 4, 2024 · 1 comment · May be fixed by #27528

Comments

@OmarHawk
Copy link

OmarHawk commented Jul 4, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

In #26034 / #21258 support for using ACR as a pull through cache was added. Unfortunately, due to rate limits on certain registries, using this without credentials tends to make nearly no sense as it makes the whole thing unreliable. The azurerm provider currently does not allow to pass credentials and requires usage of azapi or similar and makes it unnecessary complicated...

New or Affected Resource(s)/Data Source(s)

azurerm_container_registry_credential_sets

Potential Terraform Configuration

No response

References

https://learn.microsoft.com/en-us/rest/api/containerregistry/credential-sets?view=rest-containerregistry-2023-01-01-preview

@jan-mrm
Copy link
Contributor

jan-mrm commented Sep 24, 2024

Hey, if no one is working on this I'll have a look at the implementation

@jan-mrm jan-mrm linked a pull request Sep 27, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants