Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for workload profiles within azurerm_container_app Resources #22161

Closed
1 task done
colinbjohnson opened this issue Jun 14, 2023 · 5 comments · Fixed by #24219
Closed
1 task done

Support for workload profiles within azurerm_container_app Resources #22161

colinbjohnson opened this issue Jun 14, 2023 · 5 comments · Fixed by #24219

Comments

@colinbjohnson
Copy link

colinbjohnson commented Jun 14, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When building a azurerm_container_app within terraform we would like to be able to utilize a workload_profile_name property. An example of a Azure Container App (described in JSON format) that includes this property is below:

{
    "id": "/subscriptions/x/resourceGroups/my-app/providers/Microsoft.App/containerapps/my-app",
    "name": "my-app",
    "type": "Microsoft.App/containerApps",
    "location": "East US",
    "systemData": {
        "createdBy": "x",
        "createdByType": "User",
        "createdAt": "2023-06-13T18:20:56.7204791",
        "lastModifiedBy": "x",
        "lastModifiedByType": "User",
        "lastModifiedAt": "2023-06-13T18:39:11.0371897"
    },
    "properties": {
        "provisioningState": "Succeeded",
        "managedEnvironmentId": "/subscriptions/x/resourceGroups/aca-prod/providers/Microsoft.App/managedEnvironments/aca-prod",
        "environmentId": "/subscriptions/x/resourceGroups/aca-prod/providers/Microsoft.App/managedEnvironments/aca-prod",
        "workloadProfileName": "E16",
        "outboundIpAddresses": null,
        "latestRevisionName": "my-app--af7pu8m",
        "latestReadyRevisionName": "my-app--af7pu8m",
        "latestRevisionFqdn": "my-app--af7pu8m.delightfulmeadow-d01a5354.eastus.azurecontainerapps.io",
        "configuration": {
            "activeRevisionsMode": "Single",
            "dapr": null,
            "maxInactiveRevisions": null,
            "service": null
        },
        "template": {
            "revisionSuffix": "",
            "containers": [
                {
                    "image": "company.azurecr.io/my-app:latest",
                    "name": "my-app",
                    "resources": {
                        "cpu": 8,
                        "memory": "96Gi",
                        "ephemeralStorage": ""
                    },
                    "probes": []
                }
            ],
            "initContainers": null,
            "scale": {
                "minReplicas": 1,
                "maxReplicas": 1,
                "rules": null
            },
            "volumes": null,
            "serviceBinds": null
        },
        "eventStreamEndpoint": "https://eastus.azurecontainerapps.dev/subscriptions/x/resourceGroups/my-app/containerApps/my-app/eventstream"
    },
    "identity": {
        "type": "None"
    }
}

New or Affected Resource(s)/Data Source(s)

azurerm_container_app

Potential Terraform Configuration

See the additional property named workload_profile_name.

resource "azurerm_container_app" "my_app" {
  name                         = "my_app"
  container_app_environment_id = "/subscriptions/x/resourceGroups/aca-prod/providers/Microsoft.App/managedEnvironments/aca-prod"
  resource_group_name          = azurerm_resource_group.my_app.name
  revision_mode                = "Single"
  # the workload_profile_name is the property which we would like to add
  workload_profile_name        = "E16"
  template {
    container {
      name   = "my-app"
      image  = "company.azurecr.io/my-app:latest"
      cpu    = 8.0
      memory = "96Gi"
    }
  }
}


### References

_No response_
@si-te
Copy link

si-te commented Jun 21, 2023

There is a similiar issue already here: #21747

This is a very anticipated feature, as it is a requirement in enterprise settings where you have requirements for user defined routing.

@dss010101
Copy link

dss010101 commented Oct 5, 2023

You are not able to attach VNet or route traffic through a Nat Public IP for a Container App (and i assume other similar managed servicces) unless you can set Workload profiles: https://learn.microsoft.com/en-us/azure/container-apps/networking?tabs=azure-cli#environment-selection

So this is an important feature...and for us a blocker

@jackofallops
Copy link
Member

Closing as a duplicate of #21747

@dss010101
Copy link

any idea when this will be released?

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants