From 9840450ddd39412ce303e5fb49b7209c686da238 Mon Sep 17 00:00:00 2001 From: kang Date: Thu, 18 Jul 2024 09:24:43 +0800 Subject: [PATCH] Handle failure in parsing employee_hire_date field --- internal/services/users/user_resource.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/internal/services/users/user_resource.go b/internal/services/users/user_resource.go index d26306de1..0eef4dc58 100644 --- a/internal/services/users/user_resource.go +++ b/internal/services/users/user_resource.go @@ -475,7 +475,10 @@ func userResourceCreate(ctx context.Context, d *pluginsdk.ResourceData, meta int } if v, ok := d.GetOk("employee_hire_date"); ok { - employeeHireDate, _ := time.Parse(time.RFC3339, v.(string)) + employeeHireDate, err := time.Parse(time.RFC3339, v.(string)) + if err != nil { + tf.ErrorDiagF(err, "Unable to parse the provided employee_hire_date %q: %+v", v, err) + } properties.EmployeeHireDate = &employeeHireDate } @@ -588,7 +591,10 @@ func userResourceUpdate(ctx context.Context, d *pluginsdk.ResourceData, meta int } if d.HasChange("employee_hire_date") { - employeeHireDate, _ := time.Parse(time.RFC3339, d.Get("employee_hire_date").(string)) + employeeHireDate, err := time.Parse(time.RFC3339, d.Get("employee_hire_date").(string)) + if err != nil { + tf.ErrorDiagF(err, "Unable to parse the provided employee_hire_date %q: %+v", d.Get("employee_hire_date"), err) + } properties.EmployeeHireDate = &employeeHireDate }