Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new resource aws_bedrock_guardrail_version #39478

Merged
merged 11 commits into from
Sep 30, 2024

Conversation

sasidhar-aws
Copy link
Contributor

@sasidhar-aws sasidhar-aws commented Sep 25, 2024

Description

Relations

Closes #38853

References

Output from Acceptance Testing

make testacc TESTS=TestAccBedrockGuardrailVersion PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockGuardrailVersion'  -timeout 360m
=== RUN   TestAccBedrockGuardrailVersion_basic
=== PAUSE TestAccBedrockGuardrailVersion_basic
=== RUN   TestAccBedrockGuardrailVersion_disappears
=== PAUSE TestAccBedrockGuardrailVersion_disappears
=== RUN   TestAccBedrockGuardrailVersion_skipDestroy
--- PASS: TestAccBedrockGuardrailVersion_skipDestroy (73.35s)
=== CONT  TestAccBedrockGuardrailVersion_basic
=== CONT  TestAccBedrockGuardrailVersion_disappears
--- PASS: TestAccBedrockGuardrailVersion_disappears (54.64s)
--- PASS: TestAccBedrockGuardrailVersion_basic (55.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	133.252s

@sasidhar-aws sasidhar-aws requested a review from a team as a code owner September 25, 2024 03:59
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/bedrock Issues and PRs that pertain to the bedrock service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 25, 2024
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@sasidhar-aws sasidhar-aws force-pushed the f-bedrock_guardrail_version branch 3 times, most recently from 15d5f57 to 48978a2 Compare September 25, 2024 15:27
@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 25, 2024
@ewbankkit ewbankkit self-assigned this Sep 30, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 30, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBedrockGuardrailVersion_' PKG=bedrock ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/bedrock/... -v -count 1 -parallel 3  -run=TestAccBedrockGuardrailVersion_ -timeout 360m
=== RUN   TestAccBedrockGuardrailVersion_basic
=== PAUSE TestAccBedrockGuardrailVersion_basic
=== RUN   TestAccBedrockGuardrailVersion_disappears
=== PAUSE TestAccBedrockGuardrailVersion_disappears
=== RUN   TestAccBedrockGuardrailVersion_skipDestroy
--- PASS: TestAccBedrockGuardrailVersion_skipDestroy (22.48s)
=== CONT  TestAccBedrockGuardrailVersion_basic
=== CONT  TestAccBedrockGuardrailVersion_disappears
--- PASS: TestAccBedrockGuardrailVersion_disappears (14.69s)
--- PASS: TestAccBedrockGuardrailVersion_basic (16.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	43.951s

@ewbankkit
Copy link
Contributor

@sasidhar-aws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 45dbd39 into hashicorp:main Sep 30, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.70.0 milestone Sep 30, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/bedrock Issues and PRs that pertain to the bedrock service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: bedrock guardrail version
3 participants