-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Add "io2" as a valid EBS volume type to EMR validation routine #37740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix aws_emr_managed_scaling_policy for compatibility with the behavior of emr_cluster that was fixed as a part of the next problem: hashicorp#16924 hashicorp#7783
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @atsalolikhin-spokeo 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
|
info: @ewbankkit |
This reverts commit f040b65.
…r id '...' is not valid" on Read and Delete.
…`0` on create when configured.
ewbankkit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEMRInstanceGroup_instanceCount\|TestAccEMRInstanceGroup_basic' PKG=emr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/emr/... -v -count 1 -parallel 20 -run=TestAccEMRInstanceGroup_instanceCount\|TestAccEMRInstanceGroup_basic -timeout 360m
=== RUN TestAccEMRInstanceGroup_basic
=== PAUSE TestAccEMRInstanceGroup_basic
=== RUN TestAccEMRInstanceGroup_instanceCountDecrease
=== PAUSE TestAccEMRInstanceGroup_instanceCountDecrease
=== RUN TestAccEMRInstanceGroup_instanceCountCreateZero
=== PAUSE TestAccEMRInstanceGroup_instanceCountCreateZero
=== CONT TestAccEMRInstanceGroup_basic
=== CONT TestAccEMRInstanceGroup_instanceCountCreateZero
=== CONT TestAccEMRInstanceGroup_instanceCountDecrease
--- PASS: TestAccEMRInstanceGroup_instanceCountCreateZero (459.14s)
--- PASS: TestAccEMRInstanceGroup_basic (674.17s)
--- PASS: TestAccEMRInstanceGroup_instanceCountDecrease (786.38s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/emr 791.483s|
@atsalolikhin-spokeo Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for
io2EBS volume storage type toaws_emr_cluster.EC2
r5binstances supportio2since July 2021: https://aws.amazon.com/blogs/aws/amazon-ebs-io2-block-express-volumes-with-amazon-ec2-r5b-instances-are-now-generally-available/https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-supported-instance-types.html says that
r5binstances are supported in e.g., us-east-1 (Virginia), us-west-2 (oregon), etc.AWS EMR FAQ says:
EMR Management Guide says:
Adding support for
io2allows us to add Provisioned IOPS (io2) EBS volumes.The desired use case is to be able to provision an EMR cluster with
io2volumes to increase disk I/O performance for a large data processing task.Relations
Relates #20248 (which was auto-closed but is still a pain point for us).
Closes #38837.
Closes #23029.
References