[Enhancement]: Add REPOSITORY_NAME event type filter to aws_codebuild_webhook resource #38868
Labels
enhancement
Requests to existing resources that expand the functionality or scope.
service/codebuild
Issues and PRs that pertain to the codebuild service.
Description
CodeBuild has added a new filter type,
REPOSITORY_NAME
, to AWS Codebuild webhooks as described here:https://docs.aws.amazon.com/codebuild/latest/userguide/github-global-organization-webhook.html
and in the SDK here:
https://github.com/aws/aws-sdk-go-v2/blob/main/service/codebuild/types/types.go#L2638
It works with GitHub global or organization webhooks only and allows Codebuild to filter webhook triggers when the repository name matches a regex.
Unfortunately, using
REPOSITORY_NAME
results in an error:but if the resource is created manually it works and can be imported into state but including
REPOSITORY_NAME
as shown above will result in this error.As a workaround I'm considering using a lifecycle such as:
or just using repository webhooks instead of organization webhooks.
Unlike PR #38060 which added support for the
WORKFLOW_JOB_QUEUED
event pattern, supportingREPOSITORY_NAME
requires a new event type which is only available with global/organization webhooks.Maybe
REPOSITORY_NAME
would need to be added to the SDK enums here:https://github.com/aws/aws-sdk-go-v2/blob/main/service/codebuild/types/enums.go
such that
WebhookFilterType
would actually returnREPOSITORY_NAME
as a valid type? The SDK repo had a similar issue and gave a response that seems to indicate nothing can be done to fix it in the SDK:aws/aws-sdk-go-v2#2620 (comment)
since the SDK is directly code generated from the API.
Maybe the terraform provider can overcome this instead?
Affected Resource(s) and/or Data Source(s)
Potential Terraform Configuration
References
aws_codebuild_webhook
#38060WORKFLOW_JOB_QUEUED
aws/aws-sdk-go-v2#2620WORKFLOW_JOB_QUEUED
aws/aws-sdk-go-v2#2620 (comment)Would you like to implement a fix?
None
The text was updated successfully, but these errors were encountered: