Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_quicksight_folder permissions always change with multiple blocks #38840

Open
as-cyrill opened this issue Aug 13, 2024 · 3 comments
Open
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.

Comments

@as-cyrill
Copy link

as-cyrill commented Aug 13, 2024

Terraform Core Version

1.9.0

AWS Provider Version

5.62.0

Affected Resource(s)

  • aws_quicksight_folder

Expected Behavior

No change

Actual Behavior

When multiple permissions blocks are defined in aws_quicksight_folder, the order is inconsistent, causing changes to be detected every time.

      ~ permissions {
          ~ principal = "arn:aws:quicksight:XXX:XXX:user/default/userA" -> "arn:aws:quicksight:XXX:XXX:user/default/userB"
            # (1 unchanged attribute hidden)
        }
      ~ permissions {
          ~ principal = "arn:aws:quicksight:XXX:XXX:user/default/userB" -> "arn:aws:quicksight:XXX:XXX:user/default/userA"
            # (1 unchanged attribute hidden)
        }

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_quicksight_folder" "folder" {
  # ....
  permissions {
    principal = "arn:aws:quicksight:XXX:XXX:user/default/userA"
    actions   = ...
  }

  permissions {
    principal = "arn:aws:quicksight:XXX:XXX:user/default/userB"
    actions   = ...
  }
}

Steps to Reproduce

Create an aws_quicksight_folder with multiple permission blocks.
Run terraform plan

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@as-cyrill as-cyrill added the bug Addresses a defect in current functionality. label Aug 13, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/quicksight Issues and PRs that pertain to the quicksight service. label Aug 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 13, 2024
@as-cyrill as-cyrill changed the title [Bug]: aws_quicksight_folder permissions always change when multiple blocks [Bug]: aws_quicksight_folder permissions always change with multiple blocks Aug 13, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 13, 2024
@miguelhentoux
Copy link

I have the same issue on my side

@CorinneVerheyde
Copy link

I have the same issue.
I noticed that the groups/permissions are to be ordered by the ids of the groups, despite it does not appear anywhere in the code nor the state.
Our Quiciksight is using Okta groups synchronised with AWS Identity Center.
I had to order the group list by okta id in terraform to have a consistent code.
This could be a palliative, while waiting for a fix, and I hope it may help to find a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

No branches or pull requests

4 participants