Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for identity_center_configuration for redshift datasource #38347

Open
enr0c opened this issue Jul 12, 2024 · 1 comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/quicksight Issues and PRs that pertain to the quicksight service.

Comments

@enr0c
Copy link

enr0c commented Jul 12, 2024

Description

When creating a datasource from redshift to quicksight, the user has the option to enable the Identity Center Configuration, so that no user or password for the datasource has to be provided. This is documented here: https://docs.aws.amazon.com/quicksight/latest/APIReference/API_IdentityCenterConfiguration.html

This parameter is not available in https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/quicksight_data_source#redshift-argument-reference

Requested Resource(s) and/or Data Source(s)

aws_quicksight_data_source

Potential Terraform Configuration

Desired config:

resource "aws_quicksight_data_source" "redshift_idc_tip_datasource" {
  data_source_id = "21384ehczl120yu2sadf" 
  name = "redshift_idc_tip_datasource connection"
  type = "REDSHIFT"
  ssl_properties {
    disable_ssl = false
    
  }
  vpc_connection_properties {
    vpc_connection_arn = aws_quicksight_vpc_connection.qs_conn_to_vpc.arn
  }
  
  parameters  {
    redshift  {
      host     = "host"
      port     = 5439
      database = "dev"
/* 
the following parameters should be implemented - via: https://github.com/hashicorp/terraform-provider-aws/issues/38347
*/
      identity_center_configuration = {
        "enable_identity_propagation" = true
      }
    }
  }
}

Most probably here to be implemented/changed:

Most probably also the cluster_id validation, to check if its not null should be changed. Redshift serverless does not have a cluster_id

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_IdentityCenterConfiguration.html

Would you like to implement a fix?

No

Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 12, 2024
@github-actions github-actions bot added the service/quicksight Issues and PRs that pertain to the quicksight service. label Jul 12, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 22, 2024
@justinretzolk justinretzolk changed the title [New]: Add support for identity_center_configuration for redshift datasource [Enhancement]: Add support for identity_center_configuration for redshift datasource Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

No branches or pull requests

2 participants