Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add another property to support creating rules with json / yaml #37882

Open
KylePeterDavies opened this issue Jun 7, 2024 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.

Comments

@KylePeterDavies
Copy link

Description

I would like a property in aws_wafv2_rule_group that can be passed json so that I can easily orchestrate the creation of waf rules without needing to support every property that a waf can inspect in terraform.

Affected Resource(s) and/or Data Source(s)

aws_wafv2_rule_group

Potential Terraform Configuration

resource "aws_wafv2_rule_group" "rule_set" {
  name        = "Equines"
  description = "Rate Limiting for Equines API"
  scope       = "REGIONAL" 
  capacity    = 50
  rules       = jsondecode(file("equines.json"))
}

References

No response

Would you like to implement a fix?

No

@KylePeterDavies KylePeterDavies added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 7, 2024
@github-actions github-actions bot added the service/wafv2 Issues and PRs that pertain to the wafv2 service. label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 7, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 11, 2024
@dkolb
Copy link

dkolb commented Sep 14, 2024

This was done for aws_wavf2_web_acl in #38309 so it'd be nice if it could be brought to the aws_wafv2_rule_group as I can only hook into our internal security mandated terraform module by appending additional rule group references and any modules we write to create reusable and customizable rule groups hit the same complexity explosion of dynamic blocks described in #35143.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
Development

No branches or pull requests

3 participants