Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Change the default value for payload_format_version in apigatewayv2 resource #37035

Open
leandrodamascena opened this issue Apr 22, 2024 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service.

Comments

@leandrodamascena
Copy link

Description

According to the AWS documentation, apigatewayv2 uses the latest version of the payload by default, which is 2.0, but Terraform still maintains 1.0.

If you don't specify a payload format version, the AWS Management Console uses the latest version by default.

It can confuses customers that want the same experience using AWS Console and Terraform.

Thanks

Affected Resource(s) and/or Data Source(s)

aws_apigatewayv2_integration

Potential Terraform Configuration

https://github.com/hashicorp/terraform-provider-aws/blob/f2528d3edb33094a39038d34a4b06d0535c14bdc/internal/service/apigatewayv2/integration.go#L117

References

No response

Would you like to implement a fix?

Yes

@leandrodamascena leandrodamascena added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 22, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 22, 2024
@justinretzolk justinretzolk added service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 6, 2024
@leandrodamascena
Copy link
Author

Hi @justinretzolk! I would like to submit a PR changing the default version. This is my first time contributing to the project and I just wanted to make sure you're okay with it.

I will change the default version and documentation.

Thanks

@AdamTylerLynch
Copy link
Collaborator

Yes, the Terraform provider is open source and we welcome contributions!

We at AWS have published a workshop on making contributions:

https://catalog.workshops.aws/contributing-to-the-terraform-provider/en-US

For this one in particular, if you think only a documentation update is needed, you can follow this part of ther workshop:

https://catalog.workshops.aws/contributing-to-the-terraform-provider/en-US/30-development-process/70-creating-documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service.
Projects
None yet
Development

No branches or pull requests

3 participants