Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ArcThicknessOptions enum is missing ArcThicknessOptionsWhole = "WHOLE" value #36978

Open
EloiElc opened this issue Apr 18, 2024 · 2 comments · May be fixed by #37116
Open

[Bug]: ArcThicknessOptions enum is missing ArcThicknessOptionsWhole = "WHOLE" value #36978

EloiElc opened this issue Apr 18, 2024 · 2 comments · May be fixed by #37116
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.

Comments

@EloiElc
Copy link

EloiElc commented Apr 18, 2024

Terraform Core Version

1.8.0

AWS Provider Version

5.4.5

Affected Resource(s)

aws_quicksight_analysis
aws_quicksight_dashboard

Expected Behavior

To be able to set arc_thickness for PieChart to "WHOLE" value.

Actual Behavior

Unable to set arc_thickness for PieChart to "WHOLE" value.

Relevant Error/Panic Output Snippet

│ Error: expected definition.0.sheets.0.visuals.16.pie_chart_visual.0.chart_configuration.0.donut_options.0.arc_options.0.arc_thickness to be one of ["SMALL" "MEDIUM" "LARGE"], got WHOLE

Terraform Configuration Files

  visuals {
    pie_chart_visual {
      visual_id = "143a6bb1-51b0-46e4-bb7d-fcaad4f4d99e"
      chart_configuration {
        category_label_options {
          sort_icon_visibility = "HIDDEN"
          visibility           = "HIDDEN"
        }
        data_labels {
          category_label_visibility = "VISIBLE"
          label_color               = null
          label_content             = null
          measure_label_visibility  = "VISIBLE"
          overlap                   = "DISABLE_OVERLAP"
          position                  = null
          visibility                = "VISIBLE"
        }
        donut_options {
          arc_options {
            arc_thickness = "WHOLE"
          }
        }

Steps to Reproduce

Set arc_thickness to "WHOLE" value.

Debug Output

No response

Panic Output

No response

Important Factoids

arc_thickness value determines whether the chart is a pie chart or a donut chart.
arc_thickness = "WHOLE" determines that the chart is a pie chart.

References

No response

Would you like to implement a fix?

None

@EloiElc EloiElc added the bug Addresses a defect in current functionality. label Apr 18, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 18, 2024
@acwwat
Copy link
Contributor

acwwat commented Apr 26, 2024

AWS Go SDK v2 seems to have two very similar enums, ArcThickness and ArcThicknessOptions. The former has four values including WHOLE, and the latter has only three. Going by the API documentation, it seems that pie chart would use the former and gauge chart would use the latter. In the resource code, both are using the ArcThicknessOptions enum, so at least the pie chart schema would need to be fixed.

I'll see if I can confirm the exact spec on the SDK side and adjust the provider code appropriately.

@justinretzolk justinretzolk added service/quicksight Issues and PRs that pertain to the quicksight service. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
3 participants