Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Quicksight template top_bottom_filter should not require time_granularity #36013

Open
awseric opened this issue Feb 28, 2024 · 1 comment
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.

Comments

@awseric
Copy link

awseric commented Feb 28, 2024

Terraform Core Version

1.5.7

AWS Provider Version

5.38.0

Affected Resource(s)

aws_quicksight_template

Expected Behavior

No errors, terraform plan succeeds

Actual Behavior

│ Error: Missing required argument
│ 
│   on main.tf line 3049, in resource "aws_quicksight_template" "this":
│ 3049:         top_bottom_filter {
│ 
│ The argument "time_granularity" is required, but no definition was found.

Relevant Error/Panic Output Snippet

relavant terraform

resource "aws_quicksight_template" "this" {
...snip...
  filter_groups {
      filter_group_id  = "6649d98c-4d70-49e6-8e93-bfc2f3bfdf13"
      filters {
        top_bottom_filter {
          filter_id  = "1ac82f5f-85af-4555-a430-1ac71769039e"
          column {
            data_set_identifier  = "summary_view"
            column_name  = "Account"
          }
          limit  = 1
          aggregation_sort_configurations {
            column {
              data_set_identifier  = "summary_view"
              column_name  = "Cost"
            }
            sort_direction  = "DESC"
            aggregation_function {
              numerical_aggregation_function {
                simple_numerical_aggregation  = "SUM"
              }
            }
          }
        }
      }
...snip...
}


│ Error: Missing required argument
│ 
│   on main.tf line 3049, in resource "aws_quicksight_template" "this":
│ 3049:         top_bottom_filter {
│ 
│ The argument "time_granularity" is required, but no definition was found.

time granularity is not required, should be optional: https://docs.aws.amazon.com/quicksight/latest/APIReference/API_TopBottomFilter.html

Terraform Configuration Files

versions.tf

terraform {
  required_version = ">= 1.4.6"

  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = ">= 5.1.0"
    }
  }
}

Steps to Reproduce

Create any template that contains a top_bottom_filter in a filter_group without time_granularity defined.

Debug Output

No response

Panic Output

No response

Important Factoids

time granularity is not required for top bottom filters, should be optional: https://docs.aws.amazon.com/quicksight/latest/APIReference/API_TopBottomFilter.html

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_TopBottomFilter.html

Would you like to implement a fix?

Yes

@awseric awseric added the bug Addresses a defect in current functionality. label Feb 28, 2024
@github-actions github-actions bot added the service/quicksight Issues and PRs that pertain to the quicksight service. label Feb 28, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 28, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

No branches or pull requests

2 participants