Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: https://registry.terraform.io/providers/hashicorp/aws/5.19.0/docs/resources/cloudformation_stack_set_instance #34067

Open
Haykhay opened this issue Oct 23, 2023 · 2 comments
Labels
documentation Introduces or discusses updates to documentation. service/cloudformation Issues and PRs that pertain to the cloudformation service.

Comments

@Haykhay
Copy link

Haykhay commented Oct 23, 2023

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/5.19.0/docs/resources/cloudformation_stack_set_instance

Description

resource "aws_cloudformation_stack_set_instance" "example" {
deployment_targets {
organizational_unit_ids = [data.aws_organizations_organization.example.roots[0].id]
}

region = "eu-west-2"
stack_set_name = aws_cloudformation_stack_set.example.name
}
This inference to the documentation shows above However this gives error in creation, stack_set_name should read aws_cloudformation_stack_set.example.id as per attributes refrences decleared in aws_cloudformation_stack_set (https://registry.terraform.io/providers/hashicorp/aws/5.19.0/docs/resources/cloudformation_stack_set)

References

https://registry.terraform.io/providers/hashicorp/aws/5.19.0/docs/resources/cloudformation_stack_set_instance
https://registry.terraform.io/providers/hashicorp/aws/5.19.0/docs/resources/cloudformation_stack_set
No response

Would you like to implement a fix?

yes fix should be
resource "aws_cloudformation_stack_set_instance" "example" {
deployment_targets {
organizational_unit_ids = [data.aws_organizations_organization.example.roots[0].id]
}

region = "eu-west-2"
stack_set_name = aws_cloudformation_stack_set.example.name
}
None

@Haykhay Haykhay added the documentation Introduces or discusses updates to documentation. label Oct 23, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/cloudformation Issues and PRs that pertain to the cloudformation service. label Oct 23, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 23, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 23, 2023
@network-charles
Copy link
Contributor

network-charles commented Oct 23, 2023

This is so funny because using either of them works. I’d be happy to work on the issue by updating the documentation. Updating the “aws_cloudfotmstion_stack_set” resource to use “name” instead of “id” as its attribute reference improves better readability.

@Haykhay you referenced a link to the old documentation (version 5.19). However, the issue still persists in the new documentation, version 5.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/cloudformation Issues and PRs that pertain to the cloudformation service.
Projects
None yet
Development

No branches or pull requests

3 participants