Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: New Service Catalog data source "aws_servicecatalog_list_accepted_portfolio_shares" #33673

Open
Just-ZJ opened this issue Sep 28, 2023 · 3 comments · May be fixed by #33715
Open
Labels
new-data-source Introduces a new data source. service/servicecatalog Issues and PRs that pertain to the servicecatalog service.

Comments

@Just-ZJ
Copy link

Just-ZJ commented Sep 28, 2023

Description

Terraform currently lacks a data source which lists all imported portfolios for which account-to-account shares were accepted by an account. There is an equivalent in Python SDK and CloudFormation but is currently not supported by Terraform AWS Provider.

Python SDK: https://boto3.amazonaws.com/v1/documentation/api/1.26.87/reference/services/servicecatalog/client/list_accepted_portfolio_shares.html

AWS CloudFormation: https://docs.aws.amazon.com/servicecatalog/latest/dg/API_ListAcceptedPortfolioShares.html

Requested Resource(s) and/or Data Source(s)

aws_servicecatalog_list_accepted_portfolio_shares

Potential Terraform Configuration

data "aws_servicecatalog_list_accepted_portfolio_shares" "example" {
  portfolio_share_type = "AWS_ORGANIZATIONS"
}

References

https://boto3.amazonaws.com/v1/documentation/api/1.26.87/reference/services/servicecatalog/client/list_accepted_portfolio_shares.html
https://docs.aws.amazon.com/servicecatalog/latest/dg/API_ListAcceptedPortfolioShares.html

Would you like to implement a fix?

None

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/servicecatalog Issues and PRs that pertain to the servicecatalog service. label Sep 28, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 28, 2023
@Just-ZJ Just-ZJ changed the title [New Resource]: New Service Catalog resource "aws_servicecatalog_list_accepted_portfolio_shares" [New Resource]: New Service Catalog data source "aws_servicecatalog_list_accepted_portfolio_shares" Sep 28, 2023
@autotune
Copy link
Contributor

I'd like to take this on. Creating a new data source is new to me so if I am unable to do so for whatever reason I will make another comment.

@autotune
Copy link
Contributor

autotune commented Oct 2, 2023

This is mostly done just need to add tests. I modified it so it lists account status of all shares rather than just accepted.

@autotune autotune linked a pull request Oct 2, 2023 that will close this issue
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-data-source Introduces a new data source. service/servicecatalog Issues and PRs that pertain to the servicecatalog service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants