Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: support for codestar source connection for resource aws_servicecatalog_product #33211

Open
neelaruban opened this issue Aug 29, 2023 · 1 comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/servicecatalog Issues and PRs that pertain to the servicecatalog service.

Comments

@neelaruban
Copy link

Description

aws resource aws_servicecatalog_product currently only support provisioning_artifact_parameters argument under its resource specification . Recently AWS https://docs.aws.amazon.com/servicecatalog/latest/dg/API_CreateProduct.html updated its spec for Create product API with the support for the new field https://docs.aws.amazon.com/servicecatalog/latest/dg/API_CreateProduct.html#servicecatalog-CreateProduct-request-SourceConnection

Could we get some support for this enhancement so its looked into as a priority .

Affected Resource(s) and/or Data Source(s)

Resource: aws_servicecatalog_product
Data Source: aws_servicecatalog_product

Potential Terraform Configuration

resource "aws_servicecatalog_product" "example" {
  name  = "example"
  owner = "example-owner"
  type  = "CLOUD_FORMATION_TEMPLATE"

  provisioning_artifact_parameters {
    template_url = "https://s3.amazonaws.com/cf-templates-ozkq9d3hgiq2-us-east-1/temp1.json"
  }

   Source_connection  { 
      connection_parameters { 
         code_star =  { 
            artifact_path = string
            branch = string
            connection_arn = string
            repository =  string
         }
      },
      type = string
   }
  tags = {
    foo = "bar"
  }
}

References

https://docs.aws.amazon.com/servicecatalog/latest/dg/API_CreateProduct.html#servicecatalog-CreateProduct-request-SourceConnection

Would you like to implement a fix?

None

@neelaruban neelaruban added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 29, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/servicecatalog Issues and PRs that pertain to the servicecatalog service. label Aug 29, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 29, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/servicecatalog Issues and PRs that pertain to the servicecatalog service.
Projects
None yet
Development

No branches or pull requests

2 participants